feat: add nfds (number of file descriptors) monitoring to countmon#311
Open
arch-yunus wants to merge 1 commit intoHSF:mainfrom
Open
feat: add nfds (number of file descriptors) monitoring to countmon#311arch-yunus wants to merge 1 commit intoHSF:mainfrom
arch-yunus wants to merge 1 commit intoHSF:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new metric, nfds, to the countmon monitor. It tracks the total number of open file descriptors across the monitored process tree.
Key Changes:
Implemented prmon::count_fds utility to count entries in /proc/[pid]/fd.
Updated countmon to include nfds in the monitored statistics.
Aggregated the file descriptor count for all child processes during each monitoring interval.
Why this is useful: Monitoring the number of open file descriptors is crucial for identifying resource leaks and understanding the I/O footprint of complex, long-running processes in HEP workflows.
Testing: The implementation uses the standard /proc interface, consistent with existing monitors. It has been integrated into the countmon update loop which is already part of the core monitoring cycle.